Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial a11y improvements #45

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Initial a11y improvements #45

merged 1 commit into from
Feb 22, 2021

Conversation

adamjudd
Copy link
Contributor

@adamjudd adamjudd commented Nov 8, 2019

This PR includes a number of minor changes to improve a11y support in FoxyShop:

  • Switching some ID's to classes to remove potential for duplicate ID's if using shortcodes
    • foxyshop_container, productsubmit, foxyshop_main_price, foxyshop_main_product_image
  • Updating some styles to improve contrast
  • Adding unique ID to select quantity dropdown, as it is for the quantity input
  • Adding radiogroup role and aria-labelledby to radio group variations
  • Fixes a bug with update_inventory_alert_language() that wasn't correctly updating the name, it now passes the name in as an additional argument

@rijarobinson
Copy link
Contributor

Looks good.

@rijarobinson rijarobinson merged commit 91e4e26 into master Feb 22, 2021
@rijarobinson rijarobinson deleted the polish/a11y-improvements branch February 22, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamjudd @rijarobinson